OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com

Other

388 stars 115 forks source link

[Feat] Show iOS supported message #1135

Closed jkasten2 closed 10 months ago

jkasten2 commented 10 months ago

Description

1 Line Summary

Improve DX for not supported browser since it can be confusing for iOS.

Details

Validation

Tests

Tested to ensure new "...To support iOS please install as a Web App. See the OneSignal guide https://documentation.onesignal.com/docs/safari-web-push-for-ios" shows on an iPhone running iOS 16.7.2 in the JS console when using Safari.

Info

Checklist

[X] All the automated tests pass or I explained why that is not possible
[X] I have personally tested this on my machine or explained why that is not possible
[X] I have included test coverage for these changes or explained why they are not needed

Programming Checklist Interfaces:

[X] Don't use default export
[X] New interfaces are in model files

Functions:

[X] Don't use default export
[X] All function signatures have return types
[X] Helpers should not access any data but rather be given the data to operate on.

Typescript:

[X] No Typescript warnings
[X] Avoid silencing null/undefined warnings with the exclamation point

Other:

[X] Iteration: refrain from using elem of array syntax. Prefer forEach or use map
[X] Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

[X] I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

Fixes #1126

This change is