OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com
Other
383
stars
115
forks
source link
use new URL in `subscribeSafariPromptPermission` #1138
use new URL with appId in subscribeSafariPromptPermission
Details
Due to changes in our API, the appId is now required in the URL used by subscribeSafariPromptPermission. In instances where the new URL is not usable, we fallback to the legacy URL with an additional request. This ensures compatibility with both the updated and legacy API endpoints.
Systems Affected
[x] WebSDK
[x] Backend
[ ] Dashboard
Validation
Tests
Info
Checklist
[ ] All the automated tests pass or I explained why that is not possible
[ ] I have personally tested this on my machine or explained why that is not possible
[ ] I have included test coverage for these changes or explained why they are not needed
Programming Checklist
Interfaces:
[ ] Don't use default export
[ ] New interfaces are in model files
Functions:
[ ] Don't use default export
[ ] All function signatures have return types
[ ] Helpers should not access any data but rather be given the data to operate on.
Typescript:
[ ] No Typescript warnings
[ ] Avoid silencing null/undefined warnings with the exclamation point
Other:
[ ] Iteration: refrain from using elem of array syntax. Prefer forEach or use map
[ ] Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context
Screenshots
Info
Checklist
[ ] I have included screenshots/recordings of the intended results or explained why they are not needed
Description
1 Line Summary
use new URL with
appId
insubscribeSafariPromptPermission
Details
Due to changes in our API, the
appId
is now required in the URL used bysubscribeSafariPromptPermission
. In instances where the new URL is not usable, we fallback to the legacy URL with an additional request. This ensures compatibility with both the updated and legacy API endpoints.Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist Interfaces:
Functions:
Typescript:
Other:
elem of array
syntax. PreferforEach
or usemap
context
if possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.context
Screenshots
Info
Checklist
Related Tickets
This change is![Reviewable](https://reviewable.io/review_button.svg)