OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com
Remove code related to v15 APIs and behavior, such as player references.
Details
Motivation to removing this deadcode is to make upcoming changes easier to make. This PR also results in a noticeable size reduction in the SDK.
Scope
This PR addresses deleting anything related to v15 APIs and behavior. Some minor refactoring was done to clean up some related code paths.
Validation
Tests
Test on Windows 11 23H2 with Chrome 119.
addTag
Subscribing for notifications
Clicking a notification
Confirmed deliveries
Session count and time
Slidedown
Bell
Custom subscribe link
Tested on macOS 13.6.1 Safari 17.1
Subscribing for notifications
Clicking a notification
Slidedown
Bell
Custom subscribe link
Tested on iOS 16.7.2
Subscribing
Clicking a notification
Slidedown
Bell
Custom subscribe link
Info
Checklist
[X] All the automated tests pass or I explained why that is not possible
[X] I have personally tested this on my machine or explained why that is not possible
[X] I have included test coverage for these changes or explained why they are not needed
Programming Checklist
Interfaces:
[X] Don't use default export
[X] New interfaces are in model files
Functions:
[X] Don't use default export
[X] All function signatures have return types
[X] Helpers should not access any data but rather be given the data to operate on.
Typescript:
[X] No Typescript warnings
[X] Avoid silencing null/undefined warnings with the exclamation point
Other:
[X] Iteration: refrain from using elem of array syntax. Prefer forEach or use map
[X] Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context
Description
1 Line Summary
Remove code related to v15 APIs and behavior, such as player references.
Details
Motivation to removing this deadcode is to make upcoming changes easier to make. This PR also results in a noticeable size reduction in the SDK.
Scope
This PR addresses deleting anything related to v15 APIs and behavior. Some minor refactoring was done to clean up some related code paths.
Validation
Tests
Test on Windows 11 23H2 with Chrome 119.
Tested on macOS 13.6.1 Safari 17.1
Tested on iOS 16.7.2
Info
Checklist
Programming Checklist Interfaces:
Functions:
Typescript:
Other:
elem of array
syntax. PreferforEach
or usemap
context
if possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.context
Screenshots
Sizes of a production build in this PR:
Info
Checklist
Related Tickets
This change is![Reviewable](https://reviewable.io/review_button.svg)