OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com
Other
383 stars 115 forks source link

Cleanup player references #1146

Closed jkasten2 closed 6 months ago

jkasten2 commented 7 months ago

Description

1 Line Summary

Remove code related to v15 APIs and behavior, such as player references.

Details

Motivation to removing this deadcode is to make upcoming changes easier to make. This PR also results in a noticeable size reduction in the SDK.

Scope

This PR addresses deleting anything related to v15 APIs and behavior. Some minor refactoring was done to clean up some related code paths.

Validation

Tests

Test on Windows 11 23H2 with Chrome 119.

Tested on macOS 13.6.1 Safari 17.1

Tested on iOS 16.7.2

Info

Checklist

Programming Checklist Interfaces:

Functions:

Typescript:

Other:

Screenshots

Sizes of a production build in this PR:

webpack 5.80.0 compiled with 3 warnings in 8942 ms

─ ./build/bundles/OneSignalSDK.page.js
  ✔ ./build/bundles/OneSignalSDK.page.js            848B < 1 kB gzip  

─ ./build/bundles/OneSignalSDK.page.es6.js
  ✔ ./build/bundles/OneSignalSDK.page.es6.js        62.7KB < 79 kB gzip  

─ ./build/bundles/OneSignalSDK.sw.js
  ✔ ./build/bundles/OneSignalSDK.sw.js              35.33KB < 41 kB gzip  

─ ./build/bundles/OneSignalSDK.page.styles.css
  ✔ ./build/bundles/OneSignalSDK.page.styles.css    8.13KB < 9 kB gzip  

  4 checks passed   

Info

Checklist


Related Tickets



This change is Reviewable