OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com

Other

383 stars 115 forks source link

[Fix] Replace deprecated CSS 'push-button'. Adds type='button' to Custom Link Prompt. #1170

Closed marclucraft closed 2 months ago

marclucraft commented 2 months ago

Description

Fixes warning in console: [Deprecation] The keyword 'push-button' specified to an 'appearance' property is not standardized. It will be removed in the future.
Adds type="button" to the Custom Link Button. This prevents this button submitting if included in a form.

Details

Both long standing bugs.

Systems Affected

[x] WebSDK
[ ] Backend
[ ] Dashboard

Validation

Tests

Info

Checklist

[ ] All the automated tests pass or I explained why that is not possible
[x] I have personally tested this on my machine or explained why that is not possible
[ ] I have included test coverage for these changes or explained why they are not needed

Programming Checklist Interfaces:

[ ] Don't use default export
[ ] New interfaces are in model files

Functions:

[ ] Don't use default export
[ ] All function signatures have return types
[ ] Helpers should not access any data but rather be given the data to operate on.

Typescript:

[x] No Typescript warnings
[ ] Avoid silencing null/undefined warnings with the exclamation point

Other:

[ ] Iteration: refrain from using elem of array syntax. Prefer forEach or use map
[ ] Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

[x] I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

This change is