OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com

Other

388 stars 115 forks source link

Description

This pull request introduces setLanguage and getLanguage on the user class + namespace, to set the language

Details

Systems Affected

[x] WebSDK
[ ] Backend
[ ] Dashboard

Checklist

[x] All the automated tests pass or I explained why that is not possible
[x] I have personally tested this on my machine or explained why that is not possible
[x] I have included test coverage for these changes or explained why they are not needed

Validation

Changes were tested in conjunction with the a running local dev server.

Benefits

Being able to set the within the front-end SDK without needing to manually send a request to the API or use the back-end SDK

Tests

Introduced a getLanguage test in user.test.ts

This change is

@jkasten2 / @rgomezp

Would this be something you are interested in merging?

It's a feature we want to use in our project:

When registering, the browser language is selected by default. However, we can tell from our user settings what language is preferred. There current workaround is to call the REST API manually instead of using a built-in SDK function.

Let us know if we can do anything to help you getting this into this repository.

(we provided a second PR on react-onesignal to have a wrapper in there as well : https://github.com/OneSignal/react-onesignal/pull/143)