OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com
Remove sendNotification API calls and implement local notifications.
Description
We removed all instances of the sendNotification API calls to clean up dead code. The notification system has been shifted to use local notifications.
MainHelper
Added showLocalNotification to MainHelper for the welcome notification mechanism, as we no longer have sendSelfNotification
EventHelper
Updated EventHelper to use the MainHelper local notification.
Index.html
Added welcome notification configuration.
SDK Version
Updated SDK to version 160202.
Systems Affected
[x] WebSDK
[ ] Backend
[ ] Dashboard
Validation
Tested locally:
open webSDK sandbox with an app using custom code
configure index.html to send a welcome notification
subscribe
Checklist
[x] All the automated tests pass or I explained why that is not possible
[x] I have personally tested this on my machine or explained why that is not possible
[ ] I have included test coverage for these changes or explained why they are not needed
Programming Checklist
Interfaces:
[x] Don't use default export
[x] New interfaces are in model files
Functions:
[x] Don't use default export
[x] All function signatures have return types
[x] Helpers should not access any data but rather be given the data to operate on.
Typescript:
[x] No Typescript warnings
[x] Avoid silencing null/undefined warnings with the exclamation point
Other:
[x] Iteration: refrain from using elem of array syntax. Prefer forEach or use map
[ ] Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context
Screenshots
Info
Checklist
[ ] I have included screenshots/recordings of the intended results or explained why they are not needed
One line summary
Remove
sendNotification
API calls and implement local notifications.Description
We removed all instances of the
sendNotification
API calls to clean up dead code. The notification system has been shifted to use local notifications.MainHelper
showLocalNotification
toMainHelper
for the welcome notification mechanism, as we no longer havesendSelfNotification
EventHelper
EventHelper
to use theMainHelper
local notification.Index.html
SDK Version
Systems Affected
Validation
Tested locally:
Checklist
Programming Checklist Interfaces:
Functions:
Typescript:
Other:
elem of array
syntax. PreferforEach
or usemap
context
if possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.context
Screenshots
Info
Checklist
Related Tickets
This change is