Wordpress VIP - Githubissues

OneSignal / OneSignal-WordPress-Plugin

OneSignal is a free push notification service for web and mobile apps. This plugin makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com

Other

80 stars 42 forks source link

Wordpress VIP #219

Closed rgomezp closed 4 years ago

rgomezp commented 4 years ago

Intention of this PR is to fix all blocking errors to make the plugin ready for submission to Wordpress VIP

PHPCS

Used PHP Code Sniffer to fix all errors
phpcs --standard=WordPressVIPMinimum -sp --basepath=. --ignore=vendor .

Other fixes

Fixed issue on Gutenberg editor leading to double passes of the send_notification_on_wp_post hook after following comment

This change is

jkasten2 commented 4 years ago

We should setup Circle CI to run phpcs automatically since it will be important going forward that this is always passing. It doesn't have to be in this PR, but it should be in a follow up one.

davisshaver commented 4 years ago

Excited to see VIP approval in progress! 🎉

rgomezp commented 4 years ago

Excited to see VIP approval in progress! 🎉

Glad to see you're excited @davisshaver . Also, thanks for your suggestion. Please feel free to comment anywhere else you think we could make the plugin better. Cheers

rgomezp commented 4 years ago

@jkasten2 made some changes to onesignal-public.php, sorry for the back and forth

davisshaver commented 4 years ago

@rgomezp Has this been submitted to VIP for review yet? We may be asking to use it on a project and was curious if it's gone through process yet.