Enhance OneSignal widget to reflect signup status

OneSignal / OneSignal-WordPress-Plugin

OneSignal is a free push notification service for web and mobile apps. This plugin makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com

Other

80 stars 42 forks source link

Enhance OneSignal widget to reflect signup status #220

Closed davisshaver closed 15 hours ago

davisshaver commented 4 years ago

New JS approach based on official docs: https://documentation.onesignal.com/docs/web-push-custom-code-examples#section-custom-link-permission-message

Allows for multiple widgets on page
Provides new "loading" message while subscription status retrieved
Changes message/action based on subscription status
Allows unsubscription message to be changed with widget
Uses textwidget class for better default styling

This change is

rgomezp commented 4 years ago

Thanks so much for your work on this! Let us know as soon as the PR is ready for review and we'll try to review asap

davisshaver commented 4 years ago

Thank you @rgomezp, this is ready for review. I have updated the branch to include the recent changes for VIP.

rgomezp commented 11 months ago

The reason this hasn't been merged is due to limited bandwidth and because it still requires testing and approval by WP VIP team.

I don't want to close it so that it doesn't get lost