search

OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
105 stars 50 forks source link

Please consider removing dependancy on Xamarin.GooglePlayServices.Gcm #142

Closed ndastur closed 5 years ago

ndastur commented 5 years ago

Description: GCM is now depreciated in favour of FCM. The Xamarin.GooglePlayServices.Gcm package causes NuGET conflicts and it would appear is an unnecessary dependancy.

(your description here)

Environment Building a shared Xamarin Forms project Install via NuGET

Steps to Reproduce Issue: Create a blank XF project Add package such as Kinvey for mobile backend. Add OneSignal 3.1.0 package

NuGET error 

Resolving conflicts for MonoAndroid,Version=v9.0...
NU1107: Version conflict detected for Xamarin.GooglePlayServices.Basement. Install/reference Xamarin.GooglePlayServices.Basement 60.1142.1 directly to project myapp.Android to resolve this issue. 
 myapp.Android -> Kinvey 4.0.1 -> Xamarin.GooglePlayServices.Basement (>= 60.1142.1) 
 HospifyProbe.Android -> Com.OneSignal 3.3.0 -> Xamarin.GooglePlayServices.Gcm 42.1021.1 -> Xamarin.GooglePlayServices.Basement (= 42.1021.1).
rgomezp commented 5 years ago

Hello, Thanks for bringing this up. We will fix this in the next update.

Best

mengvisal commented 5 years ago

@rgomezp can you consider fixing this problem soon? We are about to release new app but now stuck with this notification issue on android.

rgomezp commented 5 years ago

@mengvisal , I'm sorry this is blocking your release. I will go ahead and elevate to HIGH* priority

xDelivered-Patrick commented 5 years ago

Hey guys - any update on this?

This is also affecting one my releases (actually we ended up taking out OneSignal, but i'd love to add it back in again). Even a beta nuget package would be greatly appreciated!

rgomezp commented 5 years ago

Hello, Sorry for the delay. We are working hard to get this done as soon as possible! Thank you for your patience.

omrishsu commented 5 years ago

This is also a blocker for us. @rgomezp do you have an ETA for this release?

rgomezp commented 5 years ago

@omrivm , Late next week

If you're a paying customer, please contact us through our official support channel at OneSignal.com

omrishsu commented 5 years ago

Any news regarding this issue?

rgomezp commented 5 years ago

@omrivm , Apologies for the delay. We are trying to release all of our SDKs as soon as possible. We really appreciate everyone's patience here. We're working extra hard to push all of the updates.

jkasten2 commented 5 years ago

The dependency for the OneSignal SDK has been changed to Firebase Messaging (FCM) in the nuspec in 3.4.0. https://github.com/OneSignal/OneSignal-Xamarin-SDK/releases/tag/3.4.0

If GCM is still in your project after the upgrade you can remove it from your packages in your project.