OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
105 stars 50 forks source link

UnsubscribeWhenNotificationsAreDisabled is not available #149

Closed jeanplevesque closed 5 years ago

jeanplevesque commented 5 years ago

Description: The boolean option "UnsubscribeWhenNotificationsAreDisabled" is available in OneSignal-Android-SDK, but is not available in the OneSignal-Xamarin-SDK.

Environment Latest OneSignal-Xamarin-SDK code base. (Commit 09c98a2 as of posting this)

Steps to Reproduce Issue:

  1. Search for "UnsubscribeWhenNotificationsAreDisabled" in the OneSignal-Xamarin-SDK code base.
  2. No results are found.

Expected Result The option should be publicly exposed through the XamarinBuilder class.

rgomezp commented 5 years ago

Thanks for your patience while we consider your request

mikechoch commented 5 years ago

Thank you for catching this, fixed in newest release 3.4.0.

jeanplevesque commented 5 years ago

I just updated to version 3.4.1 and confirm this is now present and that it works correctly. Many thanks!