Bugfix/some os notification properties not set on android

OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com

Other

105 stars 50 forks source link

Bugfix/some os notification properties not set on android #164

Closed RodgerLeblanc closed 2 years ago

RodgerLeblanc commented 5 years ago

Closes #163

This change is

RodgerLeblanc commented 5 years ago

This PR doesn't fix the issue #119 but addresses the comment from @juerweb (https://github.com/OneSignal/OneSignal-Xamarin-SDK/issues/119#issuecomment-444028714).

The OSNotification.groupedNotifications property will always be empty even when there are more than 3 notifications on Android, it seems that the binding to Android library is correct, probably the java code (onesignal-main.aar) is always returning an empty/null list, but I can't debug that part. Should I open an issue for this?

RodgerLeblanc commented 5 years ago

Correction, groupedNotifications are filled correctly when opening a notification that was grouped using a GroupKey, but is not filled when opening a notification that was grouped automatically by Android system (4 notifications or more).