search

OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
105 stars 50 forks source link

Update the NuGet dependencies #206

Closed mattleibow closed 2 years ago

mattleibow commented 4 years ago

This PR updates the dependencies and also converts to use PackageReference.

This change is Reviewable

Massimo37 commented 4 years ago

@mattleibow Hi, is there any plan to merge this PR within the next few weeks ??

mattleibow commented 4 years ago

I do not know... I just opened the PR. But, this probably can be updated again to make use of SDK style projects...

domagojmedo commented 4 years ago

@mattleibow what about using AndroidX support libraries? Are there any reasons why you didn't change packages to use those and just raised the compat support library versions instead?

mattleibow commented 4 years ago

I can't recall 😅 but there probably shouldn't be a problem.

mattleibow commented 4 years ago

I think I was just updating this to make the build a bit better for someone. This was a binding, so it is probably better to see if the underlying library is using AndroidX. We can't bind with X if it is still using support.

domagojmedo commented 4 years ago

Ah yes, seems that underlying library still isn't using AndroidX

https://github.com/OneSignal/OneSignal-Android-SDK/blob/master/OneSignalSDK/onesignal/build.gradle

jmadler commented 2 years ago

Thanks for submitting this PR. We've updated our deps in the latest branch.