Closed tanaynigam closed 2 years ago
Reviewed 10 of 10 files at r14, all commit messages. Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @tanaynigam)
_Samples/Com.OneSignal.Sample.iOS/ViewController.cs, line 45 at r14 (raw file):_
//partial void RegisterForPush(UIButton sender) //{ // SharedPush.RegisterIOS();
Make sure iOS notification prompting works, if this isn't needed remove to do that remove this commented out code.
Samples/Com.OneSignal.Sample.Shared/SharedPush.cs, line 106 at r14 (raw file):
// No effect on Android, device auto registers without prompting. //public static void RegisterIOS() { // OneSignal.Default.RegisterForPushNotification();
This method is in SharedPush, don't we need to keep it for this to work for iOS?
Replacing it with PromptForPushNotificationsWithUserResponse
Xamarin OneSignal SDK Major Release 4.0.0
Check out the migration guide to update the OneSignal SDK from version 3.x.x to version 4.x.x
You can also read all of the API changes from the changelogs
Native version
Namespace
Com.OneSignal
toOneSignalSDK.Xamarin
Bindings
.framework
to.xcframework
Java.Interop
packageOneSignalSDK.Xamarin.Core
Com.OneSignal.Abstraction
toOneSignalSDK.Xamarin.Core
OneSignalSDKInternal
toOneSignalSDK.Xamarin.Core
OneSignalSDK.Xamarin.Android
OneSignalSDK.Xamarin.iOS
OneSignalSDK.Xamarin
Sample Apps
This change is![Reviewable](https://reviewable.io/review_button.svg)