OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
104 stars 50 forks source link

Fix IOS building with OneSignal XCFramework for 4.0.0 #254

Closed jkasten2 closed 2 years ago

jkasten2 commented 2 years ago

Description

XCFrameworks require <NoBindingEmbedding>true</NoBindingEmbedding> on its binding project so consumers can link to it. This settings was referenced in https://github.com/xamarin/xamarin-macios/issues/10774#issuecomment-791518403.

It seems the consuming project (iOS sample project) can't use incremental builds as it also causes a linking error. Only an issue when building for a device, doesn't happen with the iPhoneSim target. This might be a Xamarin bug, however I haven't done a lot digging here.


This change is Reviewable