OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
104 stars 50 forks source link

Fix iOS link error for apps consuming `.nupkg` for 4.0.0 #255

Closed jkasten2 closed 2 years ago

jkasten2 commented 2 years ago

Description

Xamarin has limited support for .xcframework files, they do not have a built in working solution for NuGet packages yet. This works around the issue by including OneSignal.xcframework as-is in the .nupkg. It also includes a .target file which is settings to add the OneSignal.xcframework as a native reference. See the comment in the Com.OneSignal.nuspec file for more details.

The items under <NativeReference> in Com.OneSignal.targets is from OneSignal.iOS.Binding.csproj in this repo.

This was added based on the recommendations from:


This change is Reviewable