search

OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
104 stars 50 forks source link

Fix iOS nuget XCFramework nested path copy reference #271

Closed jkasten2 closed 2 years ago

jkasten2 commented 2 years ago

Description

One Line Summary

Fixes "OneSignal.xcframework has an incorrect or unknown format and cannot be processed" error on 4.0.0-beta1+ on iOS builds due to wrong copy path for the root contents folder where OneSignal.xcframework lives under.

Details

Our .nuspec places the OneSignal.iOS.Binding\Com.OneSignal.targets file under build\Xamarin.iOS10\ in the package so in order for it to access contents at the root it needs to go up two folder levels. PR https://github.com/OneSignal/OneSignal-Xamarin-SDK/pull/255 where this copy command was originally added had this path wrong.

Motivation

Fixes iOS build error reported by beta testers https://github.com/OneSignal/OneSignal-Xamarin-SDK/issues/262#issuecomment-1025663362

Scope

Effects all iOS builds.

Testing

Manual testing

Tested on Visual Studio Community 2019 for Mac and locally modifying ~/.nuget/packages/com.onesignal/4.0.0-beta2/build/Xamarin.iOS10/Com.OneSignal.targets to confirm it fixes the build and runs on an iOS 14 device.

This change is Reviewable