OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com

Other

104 stars 50 forks source link

[Feature] SetLanguage callback #297

Closed tanaynigam closed 2 years ago

tanaynigam commented 2 years ago

Description

One Line Summary

Add SetLanguage callback implementation to OneSignal Xamarin

Details

Motivation

SetLanguage callback returns true or false to signify success or failure when executing the setLanguage method on an app.

Scope

Update SetLanguage method type from void to Task<> in OneSignalSDKInternal of Core
Android
Add OSLanguageUpdateHandler sealed class using the IOSSetLanguageCompletionHandler interface
Update SetLanguage method type from void to Task<>
iOS
Update SetLanguage method type from void to Task<>
Add BooleanCallbackProxy to the method SetLanguage

Testing

Manual testing

Tested on Android and iOS devices to successfully execute all intended callback

Affected code checklist

[ ] Notifications
- [ ] Display
- [ ] Open
- [ ] Push Processing
- [ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[x] Public API changes

Checklist

Overview

[x] I have filled out all REQUIRED sections above
[ ] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

[x] I have included test coverage for these changes, or explained why they are not needed
[ ] All automated tests pass, or I explained why that is not possible
[x] I have personally tested this on my device, or explained why that is not possible

Final pass

[x] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item

This change is

tanaynigam commented 2 years ago

We're using delegate styles in specific scenarios such as OSUpdateLanguageSuccessBlock, OSEmailSuccessBlock and OSEmailFailureBlock predefined in the bindings that do not take any arguments in their delegate causing lambda functions to throw errors