OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
104 stars 50 forks source link

Live Activities Support #342

Closed brismithers closed 1 year ago

brismithers commented 1 year ago

Description

One Line Summary

Live Activities Support (iOS Only).

Details

This change takes advantage of the newest changes to the iOS SDK, which gives apps the ability to utilize the OneSignal platform to drive Live Activity content-state updates.

See Apple's documentation for more information on ActivityKit. See OneSignal's documentation for information on how OneSignal and LiveActivities work together.

This change does the following:

Motivation

In support of new iOS functionality.

Scope

This change adds 2 additional public methods, which invokes newly added functionality to the iOS SDK. These changes are not applicable to Android. They also do not effect existing functionality.

Testing

Manual testing

Temporary test code was created to drive the newly created methods to ensure correct behavior. On iOS the expected behavior is the call forwarded to the underlying iOS functionality. On Android the expected behavior is a log message and a failure return.

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable

fhboswell commented 1 year ago

This looks good, you note is your description version 13.12.2 it will actually need to wait for version 3.12.3 which has the bug that you pointed out fixed. Should be ready today.