search

OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
104 stars 50 forks source link

[Bug]: ITMS-90482 in App Store when publishing #349

Open eliasribeiro opened 1 year ago

eliasribeiro commented 1 year ago

What happened?

Tested in OneSignalSDK 4.1.3 and 4.3.0.

ITMS-90482 error occurs when I send the .ipa to Apple. The .ipa is reject and apple send the follow e-mail:

"App Store Connect

Dear Developer,

We identified one or more issues with a recent delivery for your app, "My App Name" 66.4 (1.65). Please correct the following issues, then upload again.

ITMS-90482: Invalid Executable - The executable 'APP.iOS.app/Frameworks/OneSignal.framework/OneSignal' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'APP.iOS.app/Frameworks/OneSignalCore.framework/OneSignalCore' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'APP.iOS.app/Frameworks/OneSignalExtension.framework/OneSignalExtension' contains bitcode.

ITMS-90482: Invalid Executable - The executable 'APP.iOS.app/Frameworks/OneSignalOutcomes.framework/OneSignalOutcomes' contains bitcode.

Best regards,

The App Store Team"

Steps to reproduce?

1. Install OneSignalSDK.Xamarin
2. Create your app.
3. Send to Apple App Store.
4. Wait inbox email for Apple email.

What did you expect to happen?

A few weeks ago I was able to publish the app without any problems. Apple changed their parsing algorithm for the .ipa caused by this issue with the OneSignalSDK.Xamarin package.

OneSignal Xamarin SDK version

4.3.0

Which platform(s) are affected?

Relevant log output

No response

Code of Conduct

brismithers commented 1 year ago

Hi @eliasribeiro there was a similar issue reported in our Unity SDK, it seems an update to Xcode 14.1 resolves the issue. Can you please try that and let me know how it goes?

Thanks!

eliasribeiro commented 1 year ago

The problem persists in XCode version 14.1.

eliasribeiro commented 1 year ago

In the recently released Xcode 14.2 the problem also persists. I tested with OneSignalSDK.Xamarin 4.3.0.

brismithers commented 1 year ago

@eliasribeiro we are seeing what we can do on the iOS native side to remove bitcode. In the mean time, I believe this will work as a workaround. It will explicitly strip the bitcode out as part of the build.

eliasribeiro commented 1 year ago

Yes, that fixed it, thanks!