OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Other
496 stars 263 forks source link

[v5] Fix forwarding notification opens from non onesignal notifs #1326

Closed nan-li closed 1 year ago

nan-li commented 1 year ago

Description

One Line Summary

Cherry-pick of https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1131 from main.

Details

Motivation

Fixing a swizzling issue where for non OneSignal notifications we were not forwarding notification opens to the app delegate remoteNotificationReceive.

Testing

Unit testing

Brought over the unit test from original PR even though it will not run.

Manual testing

No manual testing of functionality in this PR

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable