OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Other
496
stars
263
forks
source link
[v5] Fix forwarding notification opens from non onesignal notifs #1326
Fixing a swizzling issue where for non OneSignal notifications we were not forwarding notification opens to the app delegate remoteNotificationReceive.
Testing
Unit testing
Brought over the unit test from original PR even though it will not run.
Manual testing
No manual testing of functionality in this PR
tested example app runs and opening a notification only
Affected code checklist
[x] Notifications
[ ] Display
[x] Open
[ ] Push Processing
[ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes
Checklist
Overview
[x] I have filled out all REQUIRED sections above
[x] PR does one thing
[x] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
[ ] I have included test coverage for these changes, or explained why they are not needed
[ ] All automated tests pass, or I explained why that is not possible
[ ] I have personally tested this on my device, or explained why that is not possible
Final pass
[x] Code is as readable as possible.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
Description
One Line Summary
Cherry-pick of https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1131 from
main
.Details
Motivation
Fixing a swizzling issue where for non OneSignal notifications we were not forwarding notification opens to the app delegate remoteNotificationReceive.
Testing
Unit testing
Brought over the unit test from original PR even though it will not run.
Manual testing
No manual testing of functionality in this PR
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is