OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
This PR allows badges to be cleared when calling clearAll even when the disable badge clearing plist option is set to true
Details
the disable badge clearing plist option is intended to turn off the automatic badge clearing behavior that occurs when the app is opened or a notification is clicked.
This option should not be respected when the clearAll method is explicitly called because it will result in the wrong value being shown when notifications are incremented.
Additionally when the option is on we should still cache the current value instead of doing a no op incase the value has been manually set by the app.
Motivation
Fixes #1324
Scope
badge counts
Testing
Unit testing
Manual testing
tested on a physical device with the setting both on and off
Affected code checklist
[x] Notifications
[ ] Display
[ ] Open
[ ] Push Processing
[ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes
Checklist
Overview
[x] I have filled out all REQUIRED sections above
[x] PR does one thing
If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
[x] I have included test coverage for these changes, or explained why they are not needed
[x] All automated tests pass, or I explained why that is not possible
[x] I have personally tested this on my device, or explained why that is not possible
Final pass
[x] Code is as readable as possible.
Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.
Description
One Line Summary
This PR allows badges to be cleared when calling clearAll even when the disable badge clearing plist option is set to true
Details
the disable badge clearing plist option is intended to turn off the automatic badge clearing behavior that occurs when the app is opened or a notification is clicked.
This option should not be respected when the clearAll method is explicitly called because it will result in the wrong value being shown when notifications are incremented.
Additionally when the option is on we should still cache the current value instead of doing a no op incase the value has been manually set by the app.
Motivation
Fixes #1324
Scope
badge counts
Testing
Unit testing
Manual testing
tested on a physical device with the setting both on and off
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is