OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Other
496 stars 263 forks source link

[CD] code sign release binaries #1401

Closed emawby closed 6 months ago

emawby commented 7 months ago

Description

One Line Summary

Adding code signing to the binaries in the CD step

Details

We are now code signing using a OneSignal Inc Distribution certificate in our CD after building the binaries with a Lilomi Dev certificate.

These certs will needed to be updated in Github yearly.

Motivation

Apple code signing

Scope

cd

Testing

Unit testing

N/A

Manual testing

tested the workflow by adding a on pr: step

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable

nan-li commented 7 months ago

Needs changes from https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1378 We can test the next release with that PR + this one.