OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Adding code signing to the binaries in the CD step
Details
We are now code signing using a OneSignal Inc Distribution certificate in our CD after building the binaries with a Lilomi Dev certificate.
These certs will needed to be updated in Github yearly.
Motivation
Apple code signing
Scope
cd
Testing
Unit testing
N/A
Manual testing
tested the workflow by adding a on pr: step
Affected code checklist
[ ] Notifications
[ ] Display
[ ] Open
[ ] Push Processing
[ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes
Checklist
Overview
[x] I have filled out all REQUIRED sections above
[x] PR does one thing
If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
[x] I have included test coverage for these changes, or explained why they are not needed
[x] All automated tests pass, or I explained why that is not possible
[x] I have personally tested this on my device, or explained why that is not possible
Final pass
[x] Code is as readable as possible.
Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.
Description
One Line Summary
Adding code signing to the binaries in the CD step
Details
We are now code signing using a OneSignal Inc Distribution certificate in our CD after building the binaries with a Lilomi Dev certificate.
These certs will needed to be updated in Github yearly.
Motivation
Apple code signing
Scope
cd
Testing
Unit testing
N/A
Manual testing
tested the workflow by adding a
on pr:
stepAffected code checklist
Checklist
Overview
Testing
Final pass
This change is