OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com

Other

496 stars 263 forks source link

[ci] fix `swiftlint` not found by updating the action runner image #1419

Closed nan-li closed 6 months ago

nan-li commented 6 months ago

Description

One Line Summary

Fix swiftlint not found error in our CI by using macos-latest-large.

Details

macos-latest recently migrated from macOS-12 to macOS-14-arm64, the latter of which does not ship with swiftlint
macos-latest-large is macOS-14 and does ship with swiftlint
Otherwise, alternative is just keep using the old image and set macos-12

Motivation

Fix CI was broken

Scope

CI

Testing

Manual testing

CI succeeds after

Affected code checklist

[ ] Notifications
- [ ] Display
- [ ] Open
- [ ] Push Processing
- [ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes

Checklist

Overview

[ ] I have filled out all REQUIRED sections above
[ ] PR does one thing
[ ] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

[ ] I have included test coverage for these changes, or explained why they are not needed
[ ] All automated tests pass, or I explained why that is not possible
[ ] I have personally tested this on my device, or explained why that is not possible

Final pass

[ ] Code is as readable as possible.
[ ] I have reviewed this PR myself, ensuring it meets each checklist item

This change is