OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Other
496 stars 263 forks source link

Add additional 6 privacy manifests to the 6 sub-targets #1431

Closed nan-li closed 6 months ago

nan-li commented 6 months ago

Description

One Line Summary

Add additional privacy manifests to User, Notifications, LiveActivities, Outcomes, OSCore, and Core by following Apple documentation.

Details

In https://github.com/OneSignal/OneSignal-iOS-SDK/pull/1334 we added Privacy Manifest to the 4 targets that clients would import.

There was this comment in the PR:

Currently, they are not added to the other targets such as Core, Outcomes, User, etc. as these targets are already accounted for by inclusion in the umbrella OneSignalFramework target. App developers do not import these smaller modules directly but only via OneSignalFramework.

We will await feedback if the above is true and these "sub-modules" don't need a privacy manifest.

We haven't received concrete information on the last question, but since that PR, Apple has released a list of SDKs that require a privacy manifest and signature and listed the following player model SDKs, leading me to believe they do detect every sub target?

Motivation

Third-party privacy manifests required by Apple.

Scope

Privacy Manifests

Testing

Unit testing

None

Manual testing

Build and archive app, inspect the Privacy Report See the generated report for the example app OneSignalExample-PrivacyReport.pdf

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable