[Bug]: Mac Catalyst Build Breaks with Latest Release

OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com

Other

493 stars 262 forks source link

[Bug]: Mac Catalyst Build Breaks with Latest Release #1445

Closed webbpage closed 2 months ago

webbpage commented 4 months ago

What happened?

Release 5.2.0 build breaks for Mac Capacitor apps since there is no way to remove OneSignalLiveActivities.

Steps to reproduce?

Install OneSignal 5.2.0 with OneSignalXCFramework 5.2.0 (Capacitor App)
Try to deploy to Mac Catalyst. 
Errors occur related to OneSignalLiveActivities.

What did you expect to happen?

I expected the ability to turn off OneSignalLive, vs resorting to previous release.

OneSignal iOS SDK version

Release 5.2.0

iOS version

Specific iOS version

iOS 16.2

Relevant log output

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

jesus-mg-ios commented 4 months ago

Same issue here

nan-li commented 4 months ago

Hi @webbpage and @jesus-mg-ios thanks for reporting this. We will take a look at this version and Mac Catalyst.

nan-li commented 4 months ago

@webbpage can you share the Errors occur related to OneSignalLiveActivities you see?

@jesus-mg-ios are you using the native iOS SDK or a cross-platform SDK?

jesus-mg-ios commented 4 months ago

The native one, While building for Mac Catalyst, no library for this platform was found in '/Volumes/workspace/DerivedData/SourcePackages/artifacts/onesignal-xcframework/OneSignalLiveActivities/OneSignalLiveActivities.xcframework'.

webbpage commented 4 months ago

Same error received in cross-platform Capacitor SDK.

nan-li commented 4 months ago

Thanks I reproduced this and will add Mac Catalyst to supported destinations

nan-li commented 3 months ago

Hi everyone, the fix for this is in Release 5.2.1. We will need to still update our cross-platform SDKs with this update.

webbpage commented 3 months ago

I'm still getting this error with 5.2.1.

Are we suppose to do anything different our end for catalyst? iOS still works after the update.

nan-li commented 3 months ago

Hi @webbpage thanks for following up. There shouldn't be any additional steps. I'll take a look.

webbpage commented 3 months ago

Thank you for looking. Once confirmed, can you please put this bug back into open status? Please do not hesitate to reach out if you need anything from me.

webbpage commented 3 months ago

@jesus-mg-ios were you able to confirm you still had an issue with 5.2.1 ?

nan-li commented 2 months ago

Hi @webbpage thanks for your patience, we updated the Cordova SDK in Release 5.2.3 to fix the mac catalyst build error.

jesus-mg-ios commented 2 months ago

@nan-li the problem persists out of Cordova SDK.

nan-li commented 2 months ago

Hi @jesus-mg-ios can you shared your errors on version 5.2.3?

webbpage commented 2 months ago

5.2.3 is working for me. I did have to re-add the OneSignalNotificationServiceExtension target in Xcode