OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Other
496 stars 263 forks source link

Cleanup IAM window on the main thread when failing to load #1447

Closed emawby closed 5 months ago

emawby commented 5 months ago

Description

One Line Summary

Fix crash that can occur in some cases when we fail to load an IAM

Details

If multiple IAMs have the same trigger then we will have an IAM window that needs to be cleaned up when one of them fails to load. This fix was introduced in this pr, but the failure is not guaranteed to return on the UI thread so it would crash in some cases.

Motivation

Fix crash

Scope

IAM

Testing

Unit testing

none

Manual testing

Manually reproduced with break points and pausing active IAMs as they were about to load

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable