OneSignal / OneSignal-iOS-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal. https://onesignal.com
Other
496 stars 263 forks source link

[3.x.x] Replace deprecated openURL method preventing launch URLs #1493

Closed nan-li closed 1 month ago

nan-li commented 1 month ago

Description

One Line Summary

The method openURL: (doc) appears to be completely deprecated on ios 18, so replace with the updated openURL:options:completionHandler: (doc).

Details

Motivation

Tapping on launch URLs fails with iOS 18 when using the deprecated method. The user model SDK already uses the newer API.

Scope

Update a deprecated method with its replacement in 2 places (both are tested).

Testing

Unit testing

None

Manual testing

iPhone 16 simulator on iOS 18.0

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable

nan-li commented 1 month ago

The CI environment may have changed. Ran this CI 3 times, all had some tests failing after 10-11 minutes. Passes locally. The last 2 PRs ran around 3-4 minutes, all passing.