OneSignal / cli

Command line tool for OneSignal power users. 1-step iOS SDK Integration. Now in Beta.
14 stars 3 forks source link

Add File not found error handling logging #19

Closed Jeasmine closed 3 years ago

Jeasmine commented 3 years ago
Screen Shot 2021-09-15 at 17 34 49

This change is Reviewable

iAmWillShepherd commented 3 years ago
  • Changes made to the project and app build.gradle file.
    • gradlePluginPortal() added as repository provider
    • classpath "gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.12.9, 0.99.99]" dependency added
    • implementation 'com.onesignal:OneSignal:[4.0.0, 4.99.99]' dependency added
    • plugin id 'com.onesignal.androidsdk.onesignal-gradle-plugin' added

The following changes were made to build.gradle

Additionally, state the change first, e.g.

adamschlesinger commented 3 years ago

I think I would like to see the args documented like so:

Argument Description Options
type Required. Type of SDK to install. *
target Name of the App target to install in. Defaults to the entrypoint name. iOS only. *
path Path to the project directory. Defaults to the current directory. *
entrypoint iOS - Name of the target XCProject
Android - Application class file directory
For the CLI to create the file for you, you will need to provide the directory inside the project and file name with the extension where you want the Application file to be created. Example: app/src/main/java/com/onesignal/testapplication/BaseApp.java
*
lang Programming language to use. objc, swift, java, kotlin
appid OneSignal App Id. Not yet used for iOS installs. *

And as far as using the CLI I don't see a large distinction right now between args and options and I would really like to be able to invoke it as:

onesignal install-sdk 
    --type android
    --path ../MyAppDir 
    --entrypoint app/src/main/java/com/onesignal/testapplication/BaseApp.java 
    --lang java 
    --appid 1234567890