Changed the "data" parameter's platform descriptor in the Notification models from "Huawei" to "All".
Details
Motivation
I have been working on a multi-platform application implementing push notifications using the onesignal-dotnet-api. Needing to send additional information along with the notification, I was confused as the description of the "data" parameter in the Notification class, meant for this purpose, stated "Platform Huawei". I decided to try it out and it worked flawlessly both on Android and iOS, so I assumed it must have been a typo of sorts. I changed it to "All" for the Notification, NotificationWithMeta, BasicNotification and BasicNotificationAllOf classes, and relative docs. I also decided to rename it to additionalData, to match the name of the respective parameter in the OneSignal-DotNet-SDK's Notification model.
Scope
As this was a description fix involving only a parameter rename no effective change is expected to take place. That's the reason I opted to do a pull request rather than opening a new issue. Being fairly new to open source projects, I hope it was the right call to make.
Testing
Manual testing
I tested the changes on my project a few times and no problem arised on the server side (.NET MAUI Blazor Hybrid) nor on the client side (Android + iOS).
Checklist
Overview
[x] I have filled out all REQUIRED sections above
[x] PR does one thing
If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
[x] I have personally tested this on my device, or explained why that is not possible
Final pass
[x] Code is as readable as possible.
Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.
Description
One Line Summary
Changed the "data" parameter's platform descriptor in the Notification models from "Huawei" to "All".
Details
Motivation
I have been working on a multi-platform application implementing push notifications using the onesignal-dotnet-api. Needing to send additional information along with the notification, I was confused as the description of the "data" parameter in the Notification class, meant for this purpose, stated "Platform Huawei". I decided to try it out and it worked flawlessly both on Android and iOS, so I assumed it must have been a typo of sorts. I changed it to "All" for the Notification, NotificationWithMeta, BasicNotification and BasicNotificationAllOf classes, and relative docs. I also decided to rename it to additionalData, to match the name of the respective parameter in the OneSignal-DotNet-SDK's Notification model.
Scope
As this was a description fix involving only a parameter rename no effective change is expected to take place. That's the reason I opted to do a pull request rather than opening a new issue. Being fairly new to open source projects, I hope it was the right call to make.
Testing
Manual testing
I tested the changes on my project a few times and no problem arised on the server side (.NET MAUI Blazor Hybrid) nor on the client side (Android + iOS).
Checklist
Overview
Testing
Final pass