search

OneSignal / onesignal-expo-plugin

The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.
Other
153 stars 49 forks source link

[Bug]: TypeError: Cannot read properties of undefined (reading 'smallIcons') #191

Closed tomwisecodes closed 1 year ago

tomwisecodes commented 1 year ago

What happened?

On install I get this error. If I try and carry on past it it causes the prebuild to fail here also.

Steps to reproduce?

npx expo install onesignal-expo-plugin

What did you expect to happen?

Expected to be able to install one signal

OneSignal Expo SDK version

"expo": "~49.0.3", "react-native-onesignal": "^4.5.1", "onesignal-expo-plugin": "^1.3.2"

Platform

iOS

Relevant log output

at withSmallIcons (/Users/tomoak/Documents/GitHub/digin-app/node_modules/onesignal-expo-plugin/build/onesignal/withOneSignalAndroid.js:28:25)
    at withOneSignalAndroid (/Users/tomoak/Documents/GitHub/digin-app/node_modules/onesignal-expo-plugin/build/onesignal/withOneSignalAndroid.js:85:14)
    at withOneSignal (/Users/tomoak/Documents/GitHub/digin-app/node_modules/onesignal-expo-plugin/build/onesignal/withOneSignal.js:11:62)
    at withStaticPlugin (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config-plugins/build/plugins/withStaticPlugin.js:136:12)
    at /Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config-plugins/build/plugins/withPlugins.js:30:84
    at Array.reduce (<anonymous>)
    at withPlugins (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config-plugins/build/plugins/withPlugins.js:30:18)
    at withConfigPlugins (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config/build/plugins/withConfigPlugins.js:36:47)
    at fillAndReturnConfig (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config/build/Config.js:217:78)
    at Object.getConfig (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config/build/Config.js:272:10)

Code of Conduct

tomwisecodes commented 1 year ago

TypeError: Cannot read properties of undefined (reading 'smallIcons')at withSmallIcons (/Users/tomoak/Documents/GitHub/digin-app/node_modules/onesignal-expo-plugin/build/onesignal/withOneSignalAndroid.js:28:25) at withOneSignalAndroid (/Users/tomoak/Documents/GitHub/digin-app/node_modules/onesignal-expo-plugin/build/onesignal/withOneSignalAndroid.js:85:14) at withOneSignal (/Users/tomoak/Documents/GitHub/digin-app/node_modules/onesignal-expo-plugin/build/onesignal/withOneSignal.js:11:62) at withStaticPlugin (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config-plugins/build/plugins/withStaticPlugin.js:136:12) at /Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config-plugins/build/plugins/withPlugins.js:30:84 at Array.reduce () at withPlugins (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config-plugins/build/plugins/withPlugins.js:30:18) at withConfigPlugins (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config/build/plugins/withConfigPlugins.js:36:47) at fillAndReturnConfig (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config/build/Config.js:217:78) at Object.getConfig (/Users/tomoak/Documents/GitHub/digin-app/node_modules/@expo/config/build/Config.js:272:10)

mantagen commented 1 year ago

@tomwisecodes it looks like you have your plugin config incorrectly set up in app.json (or equivalent). It should read:

  "plugins": [
    // other plugins,
    ["onesignal-expo-plugin", {
      // onesignal config
    }]
  ]

You can find the Plugin config options here