rgomezp commented 10 months ago

Description

One Line Summary

Update native XCFrameworks version range and make major release.

Makes this plugin compatible with the React Native SDK as they're currently out of sync.

[x] I have filled out all REQUIRED sections above
[x] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs

[x] I have personally tested this on my device, or explained why that is not possible
[x] I have tested this on the latest version of the plugin
[x] I have tested this on both Android and iOS, or explained why that is not possible
- Tested on iOS. No Android related changes.

[x] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

pettomartino commented 9 months ago

I tried to apply this MR as patch and faced the issue @aindong is mentioning. The iOS version doesn't compile.

rgomezp commented 9 months ago

I've updated the .m file. Thanks @aindong for catching that.

@pettomartino can you apply this branch again?

lele0108 commented 9 months ago

@jkasten2 @jennantilla Possible to prioritize reviewing this small but important change? Blocking use of SDK 5 alongside Expo / EAS.

pettomartino commented 9 months ago

@rgomezp I've tested. It works!