OneSignal / onesignal-expo-plugin

The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.

Other

153 stars 49 forks source link

Add ability to set the small icon accent color #196

Closed rgomezp closed 1 year ago

rgomezp commented 1 year ago

Description

One Line Summary

Adds ability to set the small icon accent color in Android.

Motivation

Fixes https://github.com/OneSignal/onesignal-expo-plugin/issues/183

Testing

Manual testing

Tested on Android emulator device.

Screenshot 2023-09-26 at 2 10 06 PM

Checklist

Overview

[x] I have filled out all REQUIRED sections above
[x] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

[x] I have personally tested this on my device, or explained why that is not possible
[x] I have tested this on the latest version of the plugin
[x] I have tested this on both Android and iOS, or explained why that is not possible
- not necessary on iOS

Final pass

[x] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.