OneSignal / onesignal-expo-plugin

The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.
Other
142 stars 46 forks source link

Update import style shown in README #208

Closed chriszs closed 8 months ago

chriszs commented 8 months ago

Description

One Line Summary

Updates the import style shown in the README to match the current behavior.

Details

Motivation

The wrong import could confuse users who try to implement the SDK.

Testing

Manual testing

I installed react-native-onesignal 5.0 and onesignal-expo-plugin 2.0 and found that importing OneSignal direct from the library as I did before gave an undefined error. After consulting more documentation, I changed it to this style and it worked.

Checklist

Overview

chriszs commented 8 months ago

I now see that this is a dupe of #204. Only difference is whitespace.