OneSignal / onesignal-ngx

OneSignal Angular
Other
5 stars 5 forks source link

Argument type error after last update (1.0.1) #19

Closed dslak closed 2 years ago

dslak commented 2 years ago

After the last update (1.0.0 -> 1.0.1) it is no longer possible to use the notificationDisplay and notificationDismiss events getting the event as a result, in compiling these lines:

this.oneSignal.on('notificationDisplay', (event: any) => {
    [USING event OBJECT]
})

I get this error:

TS2345: Argument of type '(event: any) => void' is not assignable to parameter of type '() => void'

Probably related to this: https://github.com/OneSignal/onesignal-ngx/issues/18#issue-1225292916 Commit: https://github.com/OneSignal/onesignal-ngx/commit/98045a383941fa8afaf0a904ce928efe562f769c

rgomezp commented 2 years ago

Duplicate of #18