OneSignal / onesignal-node-api

OneSignal Node Client

Other

28 stars 12 forks source link

fix: Update README.md #53

Closed mljlynch closed 5 months ago

mljlynch commented 1 year ago

Description

A few changes to constant names in the README

Details

player is confused with playerToUpdate

Motivation

question: why is playerToUpdate not used in the subsequent description?

Testing

N/A

Checklist

Overview

[x] I have filled out all REQUIRED sections above
[x] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

[x] I have personally tested this on my device, or explained why that is not possible

Final pass

[x] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.