OneSignal / onesignal-node-api

OneSignal Node Client
Other
28 stars 12 forks source link

[Feature Request]: mix this.configuration and _options in api method #58

Open NotEvenANeko opened 1 year ago

NotEvenANeko commented 1 year ago

What's on your mind?

Mix this.configuration and _options instead of _config || this.configuration can make api easier for use.

For example I have a system which manage lots of apps, and I set userKey in the createConfiguration to manage apps. When I want to send notifications to one app, I can set the apiKey in the _options parameter, but I also need to provide parameters like baseServer, httpApi and middleware. Mix this.configuration and _options can make properties of the _options parameter optional.

Create a new DefaultApi instance every time is a way to solve this problem, but sometimes I want to make sure that only one instance exists, like using with NestJS.

Code of Conduct

NotEvenANeko commented 1 year ago

btw the link of the 'Code of Conduct' in the issue template is broken.

emawby commented 1 year ago

Thank you for reporting, this request has been noted for future releases!