OneSignal / onesignal-php-api

The official OneSignal API client for PHP
Other
21 stars 10 forks source link

Update README.md #15

Closed carnevalle closed 1 year ago

carnevalle commented 1 year ago

Description

One Line Summary

Lowercase composer require. "OneSignal/onesignal-php-api" to "onesignal/onesignal-php-api"

Details

Motivation

This fixes a bug with composer.

require.OneSignal/onesignal-php-api is invalid, it should not contain upper  
  case characters. Please use onesignal/onesignal-php-api instead.

Testing

Manual testing

Ran composer update and it worked :-)

Checklist

Overview

Testing

Final pass

iAmWillShepherd commented 1 year ago

πŸ‘‹πŸ½ @carnevalle

Thanks so much for your contribution πŸŽ‰ A member of our SDK team should get to this soon and hopefully get it merged! If we have any questions or requests, we'll @-mention you here πŸ™πŸ½

nan-li commented 1 year ago

Hey @carnevalle thank you so much for catching this.