OneSignal / onesignal-ruby-api

Other
15 stars 11 forks source link

Which SDK should we use? #37

Open edolix opened 2 hours ago

edolix commented 2 hours ago

How can we help?

Hey there!

I think there are other kind-of related issues like: #31 #34 #30 #20 #12

Looks like on rubygems there are two different SDKs:

  1. https://rubygems.org/gems/onesignal
  2. https://rubygems.org/gems/onesignal_sdk

onesignal_sdk matches OneSignal::VERSION (2.0.2) but in the installation instructions you mentioned onesignal that is still on 1.0.1.

https://github.com/OneSignal/onesignal-ruby-api/blob/6a970c476bfb41ab55d603354bec014bc6bfbbc0/lib/onesignal/version.rb#L13-L15

The repo is missing the git tag for 2.0.2 so there's a bit of confusion on which SDK should be used.

Thanks!

Code of Conduct

edolix commented 2 hours ago

Note: tried to run with onesignal_sdk and i got a NameError: uninitialized constant OneSignal from the initializer.

UPDATE:

require 'onesignal' (not necessary in 1.0.1) at the top solved it