search

OneSignal / react-native-onesignal

React Native Library for OneSignal Push Notifications Service
Other
1.57k stars 374 forks source link

OneSignal.h not found when updating from 3.x to 4.x [iOS] #1236

Closed jespejoh closed 3 years ago

jespejoh commented 3 years ago

Description: Following the steps explained here (https://documentation.onesignal.com/docs/step-by-step-react-native-3x-to-400-upgrade-guide), I try to update my project to OneSignal 4.x and no matter what I do, I always get "OneSignal.h file not found" when trying to build my project.

Screenshot 2021-06-01 at 17 57 03

I've tried adding different search paths for both the Framework Search and the Header Search (to $(inherit), to $(PROJECT_DIR) recursive, directly to the pod folder, etc, all with no success). I've also tried updating the pod repos, removing both the node_modules and the Pods folder and re-installing everything from scratch, even cleaning the cache – and still same error.

I noticed that the node_modules/react-native-onesignal/ios/ folder does not contain the OneSignal.h file anymore as it used to be with previous versions, so I tried adding it manually and then I got another error: "ld: framework not found OneSignal.xcframework". Then I tried adding the framework manually via General > Framework, Libraries and Embedded Content with no success. I also tried linking the library manually via the build phases with no success.

I've tried many potential combinations of the steps I mentioned in the two previous paragraphs, and nothing actually worked. I literally do not know what else to try, so maybe somebody run into the same issue and can shine some light on it...?

Environment

Steps to Reproduce Issue:

  1. Just try to update a project coming from react-native-onesignal 3.9.3

Anything else:

Please check screenshot attached.

rgomezp commented 3 years ago

Howdy, Have you taken a look at our Troubleshooting page?

jespejoh commented 3 years ago

Hi Rodrigo,

Thanks for your answer! Yes, I've tried everything there – still not success :/ I even tried re-installing it from scratch, and still same thing. I'm wondering if it's still somehow linked, even though I removed the paths from Frameworks / Header Paths and I still got the same error.

rgomezp commented 3 years ago

What about cleaning the build folder or deleting your Derived Data folder?

hugosjobergmedl commented 3 years ago

@rgomezp got the exact same error as mentioned in this issue. I tried cleaning the build folder and deleting the Derived Data folder without any success

jespejoh commented 3 years ago

Thanks for your answers guys! Same thing here: removing those folders, cleaning build, updating headers / frameworks path did not solve it.

Anybody else with a similar problem that solved it and can shine some light? I guess anything is worth trying at this point where nothing else worked 😅

TheWygoda commented 3 years ago

Do we have any solution? I've encountered the same issue :/

rgomezp commented 3 years ago

Howdy, Maybe take another pass at the setup instructions to see if you may have missed anything the first time you set it up. For example, the deployment target should be set to iOS 10 for maximum compatibility. The screenshot seems to indicate it may be set to version 8. I'm not sure whether that is related to the issue but it wouldn't hurt to check.

We haven't gotten too many reports of this which leads me to believe this is likely a config-related issue.

Is this occurring on M1 Macs?

One thing you can try is to clone this repository and try building the example app in the RNOneSignalTS directory. Then compare the settings between both to see if there's anything different. Or, if it's easy, you can modify the example project to serve as the base for your project and go from there.

rgomezp commented 3 years ago

Closing due to inactivity

devin-carter commented 3 years ago

Facing this issue with react native 0.63.3, react-native-onesignal ^4.3.1 on an intel mac.

Have tried setup from scratch following instructions several times, everything from the troubleshooting page, and from this thread.

naveenPaulsingh commented 2 years ago

It may be an issue because of platform version mismatch between your podfile and notification service extension. This answer solved the above issue.

https://github.com/OneSignal/react-native-onesignal/issues/838#issuecomment-665205966

Seamus1989 commented 1 year ago

nope, it isn't. I've done everything, all suggestions I've found haven't worked. I've followed the set up exactly and also compared to the examples given. I'm all out of ideas