search

OneSignal / react-native-onesignal

React Native Library for OneSignal Push Notifications Service
Other
1.57k stars 373 forks source link

[Feature] Request to support "React Native Web" #1390

Open hyochan opened 2 years ago

hyochan commented 2 years ago

Description: These days, web support for React Native is good enough to land in production. I think it'd be nice if onesignal react-native supports web.

Environment React Native Web ^0.17.7

Steps to Reproduce Issue: import OneSignal from 'react-native-onesignal'; in web.

Anything else: Here is the screenshot running in expo web.

Screen Shot 2022-05-06 at 3 04 29 PM
jkasten2 commented 2 years ago

@hyochan Thanks for the feature request, we will consider adding support for "React Native Web".

We also do have an SDK for "React" (AKA React.js or ReactJS) called react-onesignal. While not as nice has having one library and API wanted to point it out as an easy way to still integrate OneSignal on your website today.

mauricedoepke commented 1 year ago

@jkasten2 The expo guy just anounced a huge step towards making it esier to build rn apps for the web (universal routing that works the same on web + native): https://blog.expo.dev/announcing-the-expo-router-v1-release-candidate-c5680b88a18c

It would be really awesome to see the rest of the ecosystem support this universal approach, having web + native support in a single library,as well. That could safe lots of development effort.

Martijncvv commented 9 months ago

Description: These days, web support for React Native is good enough to land in production. I think it'd be nice if onesignal react-native supports web.

Environment React Native Web ^0.17.7

Steps to Reproduce Issue: import OneSignal from 'react-native-onesignal'; in web.

Anything else: Here is the screenshot running in expo web. Screen Shot 2022-05-06 at 3 04 29 PM

Heey, How did you fix this in the end. Implement both ways and just ignore the react-native error when used in web?