OneSignal / react-native-onesignal

React Native Library for OneSignal Push Notifications Service
Other
1.57k stars 373 forks source link

[Bug]: fallback to settings prompt is shown when calling requestPermission(false) #1613

Open Redn4s opened 10 months ago

Redn4s commented 10 months ago

What happened?

When requesting the push permission after the user already declined push permissions, the "Open settings" prompt is still shown even when I pass false when calling requestPermission().

OneSignal.Notifications.requestPermission(false) // Still shows the "Open settings" alert

Steps to reproduce?

1. Install v5.0.4 of react-native-onesignal
2. Call `requestPermission(false)`
3. Decline the push permission
4. Call `requestPermission(false)` again
5. The "Open settings" prompt is shown

What did you expect to happen?

I expect the "Open settings" prompt not to show up when I call requestPermission(false) after the user already declined push permissions.

React Native OneSignal SDK version

5.0.4

Which platform(s) are affected?

Relevant log output

No response

Code of Conduct

andrewdazs commented 9 months ago

I was also getting this error and the problem was that I was calling requestPermission() twice inside the codebase. calling it only once solved the problem.

BijuDey commented 7 months ago

I was also getting this error and the problem was that I was calling requestPermission() twice inside the codebase. calling it only once solved the problem.

I have called it just once still same issue

unknwngera commented 6 months ago
OneSignal.Notifications.canRequestPermission().then(can => {
  if (can) OneSignal.Notifications.requestPermission(false)
})

solves this problem