OneSignal / react-onesignal

React OneSignal Module: Make it easy to integrate OneSignal with your React App!
Other
74 stars 23 forks source link

Provide types for external use #141

Open ElwynVdb opened 2 months ago

ElwynVdb commented 2 months ago

Overview

This pull request contains the exporting of the type definitions within the index.ts file.

Benefits

Related open issues

veewee commented 1 month ago

@jkasten2 / @rgomezp

Not having decent type reusability in typescript is a bit annyoing: If we want to accept e.g. an IOSNotification object in one of our functions - there is no way to type it with typescript other than including the type directly in the project. Making it vulnerable for future API updates where the type in our project won't match the one-signal type anymore.

Would this be something you are interested in merging? Let us know if we can do anything to help you getting this into this repository.