search

OneSignal / react-onesignal

React OneSignal Module: Make it easy to integrate OneSignal with your React App!
Other
73 stars 26 forks source link

Properly fix IOneSignalEventCallback #46

Closed emzoumpo closed 3 years ago

emzoumpo commented 3 years ago

After fix done in #23, IOneSignalEventCallback is not used anymore. Instead of hardcoding the callback type, we can turn the interface to a type and use it the way it was intended to be used from the beginning. That way we can also use the callback type in other places in the future.

emzoumpo commented 3 years ago

@pedro-lb let me know if you'd like me to do any other adjustments!

emzoumpo commented 3 years ago

Not applicable to version 2