OneSignal / serde-magnus

Serde bindings for Magnus Ruby crate
MIT License
4 stars 9 forks source link

String/Symbol consistency #11

Closed saty9 closed 8 months ago

saty9 commented 8 months ago

Currently Enums use strings both for unit enums and newtype enums but structs use symbols this leads to odd looking ruby hashes with mixes of bottle rocket and symbol syntax.

Could everything use either strings or symbols. My personal preference is symbols as I think the notation is cleaner. Alternatively could the behaviour be changed using features.

Happy to do the work for this and submit a PR but would like to know there is appetite for this before getting started.