search

OneSignal / serde-magnus

Serde bindings for Magnus Ruby crate
MIT License
4 stars 9 forks source link

String/Symbol consistency #13

Open saty9 opened 8 months ago

saty9 commented 8 months ago

Currently Enums use strings both for unit enums and newtype enums but structs use symbols this leads to odd looking ruby hashes with mixes of hash rocket and symbol syntax.

Could everything use either strings or symbols. My personal preference is symbols as I think the notation is cleaner. Alternatively could the behaviour be changed using features.

Happy to do the work for this and submit a PR but would like to know there is appetite for this before getting started.

saty9 commented 8 months ago

Apologies for spam I'm on a train and went through a dead patch and got a little refresh button happy

ianmurrays commented 7 months ago

I'm also interested in this