OneSignalDevelopers / ngosi

Share your slides with a QR code
https://ngosi.io
MIT License
9 stars 5 forks source link

Center auth component on login page #45

Closed Yohanan-Negash closed 2 years ago

Yohanan-Negash commented 2 years ago

Fixes : #22

Solution

I added some CSS properties that center the Auth component on the login page.

Testing

  1. Start the supabase CLI, supabase start
  2. yarn dev, to start the dev server
  3. Navigate to localhost:3000/signin (signin page) and observe the change made on the auth component

Resources

Before adding styles
Screen Shot 2022-01-01 at 1 11 05 AM
After adding styles
Screen Shot 2022-01-01 at 1 09 49 AM
vercel[bot] commented 2 years ago

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/onesignaldevs/settings/billing.
iAmWillShepherd commented 2 years ago

This PR doesn't address the change indicated in the title, but makes changes to the homepage instead. This PR conflicts with PR#43 and we have a couple of options we can take to resolve the issue:

  1. Merge the base branch of PR #43 into this branch
  2. Close this PR and merge changes into the base branch of PR #43

I don't there's a way of avoiding merge conflicts, so I think option one would be best. Also, the testing steps don't work for anyone trying to run this. Refer to PR #43 for one good testing steps look like.

Fwiw, this is the account page (note that the page is served at the /accountroute):

Screen Shot 2022-01-02 at 7 18 26 PM
iAmWillShepherd commented 2 years ago

I changed the base branch of this PR (the conflicts need to be taken care of). Please update your PR title and description to highlight that these updates are for the login page, not the account page.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onesignaldevs/ngosi/8KZQzmS5NNVJytTrLsC31MPFJd4o
✅ Preview: https://ngosi-git-account-page-styling-onesignaldevs.vercel.app

Yohanan-Negash commented 2 years ago

Since this PR conflicts with PR #43 I merged the base branch of PR #43 into this one as you suggested.