Animation frame rates - Githubissues

OneZoom / OZtree

OneZoom Tree of Life Explorer

Other

91 stars 20 forks source link

Animation frame rates #910

Open jaredkhan opened 1 day ago

jaredkhan commented 1 day ago

Animations including:

Zooming using the +/- buttons
Flights on the tree (e.g clicking on search results)
Direct flights (e.g. signpost clicks) should aim to run at the display refresh rate and should be frame-rate-independent so that the animation speed is similar regardless of the frame rate and of frames being dropped. This should result in these animations feeling much more pleasant to look at.

Currently, frame rates for some of these animations are set very low (zooms at 30FPS, flights at 16FPS) and all assume fixed time step which can cause a little jitteriness.

davidebbo commented 17 hours ago

What about scroll wheel zooming? Right now, it has no animation at all. It's direct jump. Although each notch only zooms in a little, so it's not terrible. I think it ends up being similar to the +/- buttons.

jaredkhan commented 15 hours ago

Yeah scrolling could do with some work too but I’ll make a separate issue for that. I have a prototype of smooth scrolling that I can send you later on in fact 😊

davidebbo commented 15 hours ago

Yeah scrolling could do with some work too but I’ll make a separate issue for that. I have a prototype of smooth scrolling that I can send you later on in fact 😊

To make sure there is no misunderstanding, I'm referring to the scroll wheel on my mouse, which has a zoom in/out effect. Is that in fact what you meant as well?

jaredkhan commented 12 hours ago

Mmh well I mean scrolling on a trackpad or a continuous mouse wheel as opposed to a clicky mouse wheel but similar effect I suspect. There's a branch here if you want to have a play, it's not really ready for a pull request yet: https://github.com/jaredkhan/OZtree/tree/fix-text-jitter

I did it whilst working on text jitter stuff because on desktop there isn't currently a way to gently zoom, only sharp snappy zooming. That branch pays attention to the 'delta' on the wheel event so as to zoom less when you make smaller movements.

Perhaps for a discrete 'clicky' mouse wheel we would need something more.

davidebbo commented 10 hours ago

Getting a conflict on that branch. Mind fixing that up? Happy to play with it.