search

OneZoom / tree-build

Scripts for assembling the tree, metadata and downstream data products such as popularity and popular images
MIT License
1 stars 2 forks source link

Suggestions for extra tests for wiki harvesting #88

Open hyanwong opened 2 months ago

hyanwong commented 2 months ago

I'll have a go at adding these:

  1. Tests which are not normally run, as they require online access a. Check that definitions in _OZglobals.py (e.g. wikiflags and src_flags) match the versions in the same file in the latest OZtree repo b. get -- real-apis to work (see https://github.com/OneZoom/tree-build/issues/71, and find the best way to implement something similar for tests in the TestAPI class)

  2. Check process_clade (see #72 )

  3. Check crop positioning (manual setting and also that the mocked Azure crop successfully returns the correct portion of the image.

davidebbo commented 2 months ago

The "get --real-apis to work" part is done, as of 08b9233915b1bc329147eb35f25faa6a19a5deb5. Please check that you can run it without errors.

hyanwong commented 2 months ago

Thanks. I presume it might be useful to figure out how to get --real-apis to work with the tests in the testAPI class? AT the moment the tests are only done for the full pipeline (i.e. TestCLI). But perhaps that's enough anyway?

davidebbo commented 2 months ago

My take is that full pipeline is sufficient, and most represents what we actually run in real use. Of course, more tests is always better, but in this case I think there is diminishing return.