Default value inconsistent in description - Githubissues

Oneflow-Inc / models

Models and examples built with OneFlow

Apache License 2.0

94 stars 37 forks source link

Default value inconsistent in description #389

Closed howiejayz closed 1 year ago

howiejayz commented 1 year ago

As I saw in https://github.com/Oneflow-Inc/models/tree/main/RecommenderSystems/dlrm#arguments-description, the default value for --store_type is cached_ssd, which is different from the setting in https://github.com/Oneflow-Inc/models/blob/main/RecommenderSystems/dlrm/dlrm_train_eval.py.

MARD1NO commented 1 year ago

Thanks for your feedback, it has been fixed in https://github.com/Oneflow-Inc/models/pull/390