/oneflow/oneflow/xrt/xla/ops/scalar_binary_op.cpp:47:3: error: control reaches end of non-void function [-Werror=return-type]

[qianzhang613]

the line 47 of /oneflow/oneflow/xrt/xla/ops/scalar_binary_op.cpp :

  xla::XlaOp Scalar(XlaOpContext *ctx) const {
    xla::XlaBuilder *builder = ctx->builder();
    DataType data_type = ctx->SoleInputType();
    if (ctx->Attr<bool>("has_int_operand")) {
      int64_t value = ctx->Attr<int64_t>("int_operand");
      return IntegerLiteral(builder, data_type, value);
    } else if (ctx->Attr<bool>("has_float_operand")) {
      double value = ctx->Attr<double>("float_operand");
      return FloatLiteral(builder, data_type, value);
    }
  }

need add return statement.

[Ldpe2G]

@qianzhang613 you can quickly fix this by removing the -Werror=return-type option in CMakeLists.txt. Then retype cmake and recompile.

https://github.com/Oneflow-Inc/oneflow/blob/master/CMakeLists.txt#L123

[qianzhang613]

@qianzhang613 you can quickly fix this by removing the -Werror=return-type option in CMakeLists.txt. Then retype cmake and recompile.

https://github.com/Oneflow-Inc/oneflow/blob/master/CMakeLists.txt#L123

ok, that works thanks.

it is better to just add error return at the end.